1042322 - [Open 2] Lock screen overlay covers up lock screen text

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Marcia Knous [:marcia]]

Attachment: 2014-07-22-17-15-52.png

Open 2, while running:

Gaia   b9d19011123487009c80d1200937652d58c434a0
SourceStamp 00f4b3a7046f
BuildID 20140722000200
Version 32.0

STR:
1. Lock the device using the command from the website.
2. Set a passcode lock on the device.
3. Observe the attached screenshot.

Comment 1

[Erin Lancaster [:elan]]

Does this repro on the Flame, per chance?

Comment 2

[Kate Glazko]

Does not repro on Flame 2.0.0. 273 Mb.

Comment 3

[Marcia Knous [:marcia]]

Display specs for the device:

Display 	Type 	TFT capacitive touchscreen
Size 	320 x 480 pixels, 3.5 inches (~165 ppi pixel density)

Comment 4

[:gerard-majax]

What should be the proper UX in this case ? I can't find a good solution by myself :(

Comment 5

[Stephany Wilkes]

This is the first time UX has been flagged on this, and today is Feature Landing. Setting ni? to Francis.

Comment 6

[Francis Djabri [:djabber]]

Assigning to Rob.

Comment 7

[Rob MacDonald [:robmac]]

Hi Marcia... 

For the attached screenshot, how did you generate the text in the background? And is there a way I can easily reproduce this on Flame? 

This text does not appear to be a notification as it does not match the visual design and, on my build, the notifications disappear when the PIN entry form is triggered... which is as designed.

Please NI me when you respond.

Thanks!
Rob

Comment 8

[Marcia Knous [:marcia]]

Rob: The last time we tried this did not repro on the Flame - I only saw it on the Open 2 which has a much smaller screen.

The text is generated by doing the following:

1. Go into settings and select find my device.
2. Create an account and confirm it (suggest using https://www.mailinator.com/ since it is fast and throwaway)
3. After confirming your account, log into https://find.firefox.com/
4. Select lock - you can then type some text into the text box and it will show up on your phone.

Comment 9

[Rob MacDonald [:robmac]]

Thanks, Marcia...

I'd propose we use the two step unlock fix from 2.0 could fix this. The message could show up on the screen with the unlock mechanism and then be hidden when the unlock PIN keypad is displayed.

NI'ing Jacqueline to confirm the behaviour and Amy to confirm visual design.

- Rob

Comment 10

[Jacqueline Savory [:jsavory] UX]

I agree that this behaviour is the best option, it will allow the users to see the notification without overlapping the Pin keypad.

Comment 11

[Adam Alldredge [:AdamA][Inactive]]

Qawanted at Qanalysts cannot check this bug. we do not have an Open 2 which is needed for this.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Adam Alldredge [:AdamA] from comment #11)
> Qawanted at Qanalysts cannot check this bug. we do not have an Open 2 which
> is needed for this.

Have you checked if this happens on Flame?

Comment 13

[Adam Alldredge [:AdamA][Inactive]]

I was unable to reproduce this issue on 2.2 Flame. The lock screen overlay never covered up the text.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140903115424
Gaia: af04d8bc2111d4ea146239a89ff602206b85eaf5
Gecko: 117271830c4d
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 14

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

Just realized this isn't a regression - it's specific to Open II & reproduces on 2.0. If it's present on already shipping device, then why are we blocking on this?

Comment 15

[Tony Chung [:tchung]]

[Blocking Requested - why for this release]:

please qawanted this on 2.1, and see if this is still reproducible.   Test against an open 2 build.

Comment 16

[Amy Lee [:amylee] UX]

(In reply to Rob MacDonald [:robmac] from comment #9)
> Thanks, Marcia...
> 
> I'd propose we use the two step unlock fix from 2.0 could fix this. The
> message could show up on the screen with the unlock mechanism and then be
> hidden when the unlock PIN keypad is displayed.
> 
> NI'ing Jacqueline to confirm the behaviour and Amy to confirm visual design.
> 
> - Rob

The current message box doesn't follow the visual design of the OS. I will post a spec shortly to update the text box visuals.

Comment 17

[Tony Chung [:tchung]]

(In reply to Amy Lee [:amylee] from comment #16)
> (In reply to Rob MacDonald [:robmac] from comment #9)
> > Thanks, Marcia...
> > 
> > I'd propose we use the two step unlock fix from 2.0 could fix this. The
> > message could show up on the screen with the unlock mechanism and then be
> > hidden when the unlock PIN keypad is displayed.
> > 
> > NI'ing Jacqueline to confirm the behaviour and Amy to confirm visual design.
> > 
> > - Rob
> 
> The current message box doesn't follow the visual design of the OS. I will
> post a spec shortly to update the text box visuals.

hi amy, is this done yet?   can you needinfo marcia and myself when you have this completed, so we can retest what we see?  Thanks.

Comment 18

[Amy Lee [:amylee] UX]

(In reply to Tony Chung [:tchung] from comment #17)
> (In reply to Amy Lee [:amylee] from comment #16)
> > (In reply to Rob MacDonald [:robmac] from comment #9)
> > > Thanks, Marcia...
> > > 
> > > I'd propose we use the two step unlock fix from 2.0 could fix this. The
> > > message could show up on the screen with the unlock mechanism and then be
> > > hidden when the unlock PIN keypad is displayed.
> > > 
> > > NI'ing Jacqueline to confirm the behaviour and Amy to confirm visual design.
> > > 
> > > - Rob
> > 
> > The current message box doesn't follow the visual design of the OS. I will
> > post a spec shortly to update the text box visuals.
> 
> hi amy, is this done yet?   can you needinfo marcia and myself when you have
> this completed, so we can retest what we see?  Thanks.

Hi, 

Just waiting on Jacqueline for feedback. Will post when ready. Thanks!

Comment 19

[Jacqueline Savory [:jsavory] UX]

Sorry for the delay here, I've given feedback to Amy so she should have an update soon.

Comment 20

[Jason Smith [:jsmith]]

(In reply to Tony Chung [:tchung] from comment #15)
> [Blocking Requested - why for this release]:
> 
> please qawanted this on 2.1, and see if this is still reproducible.   Test
> against an open 2 build.

Marcia - Can you do this qawanted request?

Comment 21

[Amy Lee [:amylee] UX]

Attachment: Find_My_Device_Message_Spec.pdf

Hi, 

I've attached the VSD spec. Let me know if you have any questions.

Thanks

Comment 22

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hi Vishy - Based on comment 14, seems like this should not block for 2.1. Can you confirm? Thanks!

Comment 23

[Amy Lee [:amylee] UX]

Attachment: Find_My_Device_Message_Spec.pdf

Minor edit to the transparency of the FMD background from 90% to 94%.

Comment 24

[vkrishnamoorthy]

waiting on qawanted

ni:tony

Comment 25

[Marcia Knous [:marcia]]

Attachment: Screenshot with latest base image, Open C

I still see this when I flash the most current Open C base image + shallow flash of Gecko and Gaia. Note the fonts are missing because of the shallow flash.

Comment 26

[Tony Chung [:tchung]]

Attachment: screenshot on Open 2 in Lock mode with keypad

I also see the same thing on a 2.1 build, ZTE Open 2 (3.5" screen).  Amy, what should the UX look like when the lockscreen is enabled?

Comment 27

[Stephany Wilkes]

Flagging Amy to address Tony's comment #26.

Comment 28

[Amy Lee [:amylee] UX]

(In reply to Stephany Wilkes from comment #27)
> Flagging Amy to address Tony's comment #26.

Hi Tony, 

The visual design should be the same on all devices and based on the spec I provided in comment 23.
The behaviour would follow what Rob proposed in comment 9.


Thanks

Comment 29

[Tony Chung [:tchung]]

okay thanks.  ni: jackie and rob if the seen behavior in comment 25 and 26 is acceptable for 2.1.  If its not, this should be blocking 2.1+ and assigned.

Comment 30

[Jacqueline Savory [:jsavory] UX]

As Rob mentioned in comment 9, the message should be hidden on the pin unlock screen, and only display on the screen with the unlock mechanism. 

For the examples shown in comment 25 and 26, this is not following the proposed behaviour as the message should no longer be visible since the user has reached the pin unlock screen.

Comment 31

[bhavana bajaj [:bajaj]]

Given UX feedback, I really want this fixed before FC but would not technically block the release. Once fixed, can you seek approval here to uplift this?

Comment 32

[BMO Automation]

Firefox OS is not being worked on